change identity comparisons to use isequal #16764
Conversation
|
Yes, the behavior change to |
| end | ||
| findlast(A, v) = findprev(A, v, length(A)) | ||
|
|
||
| # returns the index of the previous element for which the function returns true, or zero if it never does | ||
| function findprev(testf::Function, A, start::Integer) | ||
| for i = start:-1:1 | ||
| testf(A[i]) && return i | ||
| if testf(A[i]) |
There was a problem hiding this comment.
Why make this change here and not above? (Anyway, that's clearly unrelated to this PR...)
Agreed: this should be in its own PR and merged immediately. |
the external abi is to call var, the internal abi doesn' need to branch to alternative functions based on whether mean is given as zero that simply made the dispatch less straightforward to understand even though doing an exact comparison to 0 isn't generally reliable ref #6273, which initially introduced these functions as the public API, before changing them to be the internal implementation
I'll merge in the morning, if there's no further comments |
| mode = have_file ? "r+" : "w+" | ||
| end | ||
| workermode = mode == "w+" ? "r+" : mode # workers don't truncate! | ||
|
|
||
| # Ensure the file will be readable | ||
| mode in ("r", "r+", "w+", "a+") || throw(ArgumentError("mode must be readable, but $mode is not")) | ||
| init==false || mode in ("r+", "w+", "a+") || throw(ArgumentError("cannot initialize unwritable array (mode = $mode)")) | ||
| if init !== false | ||
| typeassert(init, Function) |
There was a problem hiding this comment.
This typeassert seems to add a restriction that was not here before.
There was a problem hiding this comment.
good call. I added this so that init isn't silently ignored later (https://github.com/JuliaLang/julia/pull/16764/files/e6e1312a051d9b5511bf5b4f9ea0ae97528bb5ed#diff-6ba74fe8f18fa73bec8dfbfd1801a05cL209), but that test is wrong too
There was a problem hiding this comment.
what are you trying to link to?
|
This broke JuliaStats/StatsBase.jl#169, which depends on |
|
should either revert e6e1312 or add a deprecation. DataArrays uses it too. |
this makes it now possible to make
==with non-comparable items an error (ref #15983), since these notions are no longer coupled, but it does not make that change nowit does changeedit: now extracted from this PR to jn/notequal...jn/in-isequalinto useisequal(#9381), but that's a small part of the change, so I might move that to another branch while that issue is still under discussion